<html>
<head><meta charset="utf-8"><title>Toolstate update was broken for Miri · t-infra · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/index.html">t-infra</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Toolstate.20update.20was.20broken.20for.20Miri.html">Toolstate update was broken for Miri</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="226565771"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Toolstate%20update%20was%20broken%20for%20Miri/near/226565771" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> hyd-dev <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Toolstate.20update.20was.20broken.20for.20Miri.html#226565771">(Feb 16 2021 at 19:44)</a>:</h4>
<p>I noticed that something weird happened: <a href="https://github.com/rust-lang/rust/pull/82150#issuecomment-780062735">https://github.com/rust-lang/rust/pull/82150#issuecomment-780062735</a><br>
I think that PR should fix Miri, but Miri is still in "test fail" state: <a href="https://rust-lang-nursery.github.io/rust-toolstate/">https://rust-lang-nursery.github.io/rust-toolstate/</a><br>
As the website says it "reflects the real-time status on the master branch", and the error message looks bad, I think it may be broken?</p>



<a name="226622265"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Toolstate%20update%20was%20broken%20for%20Miri/near/226622265" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> kennytm <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Toolstate.20update.20was.20broken.20for.20Miri.html#226622265">(Feb 17 2021 at 07:38)</a>:</h4>
<div class="codehilite"><pre><span></span><code>2021-02-16T19:22:22.1050616Z /home/runner/work/rust/rust/src/tools/publish_toolstate.py:121: DeprecationWarning: &#39;U&#39; mode is deprecated
2021-02-16T19:22:22.1051919Z 📣 Toolstate changed by rust-lang/rust#82150!
2021-02-16T19:22:22.1052706Z   with open(path, &#39;rU&#39;) as f:
...
2021-02-16T19:22:22.3105756Z Traceback (most recent call last):
2021-02-16T19:22:22.3106565Z   File &quot;/home/runner/work/rust/rust/src/tools/publish_toolstate.py&quot;, line 338, in &lt;module&gt;
2021-02-16T19:22:22.3107469Z     response = urllib2.urlopen(urllib2.Request(
2021-02-16T19:22:22.3108244Z   File &quot;/usr/lib/python3.8/urllib/request.py&quot;, line 222, in urlopen
2021-02-16T19:22:22.3108949Z     return opener.open(url, data, timeout)
2021-02-16T19:22:22.3109632Z   File &quot;/usr/lib/python3.8/urllib/request.py&quot;, line 522, in open
2021-02-16T19:22:22.3110207Z     req = meth(req)
2021-02-16T19:22:22.3110797Z   File &quot;/usr/lib/python3.8/urllib/request.py&quot;, line 1281, in do_request_
2021-02-16T19:22:22.3111441Z     raise TypeError(msg)
2021-02-16T19:22:22.3112328Z TypeError: POST data should be bytes, an iterable of bytes, or a file object. It cannot be of type str.
</code></pre></div>



<a name="226622315"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Toolstate%20update%20was%20broken%20for%20Miri/near/226622315" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> kennytm <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Toolstate.20update.20was.20broken.20for.20Miri.html#226622315">(Feb 17 2021 at 07:38)</a>:</h4>
<p>feels like some python 2 → 3 fallout.</p>



<a name="226668340"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Toolstate%20update%20was%20broken%20for%20Miri/near/226668340" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> hyd-dev <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Toolstate.20update.20was.20broken.20for.20Miri.html#226668340">(Feb 17 2021 at 15:02)</a>:</h4>
<p>Maybe the <code>master</code> job does not use a container, and <code>ubuntu-latest</code> was changed to <code>ubuntu-20.04</code> now: <a href="https://github.com/rust-lang-ci/rust/runs/1913286475#step:1:4">https://github.com/rust-lang-ci/rust/runs/1913286475#step:1:4</a><br>
And <code>ubuntu-20.04</code> uses Python 3 by default: <a href="https://github.com/actions/virtual-environments/issues/1591">https://github.com/actions/virtual-environments/issues/1591</a></p>



<a name="226670410"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Toolstate%20update%20was%20broken%20for%20Miri/near/226670410" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> hyd-dev <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Toolstate.20update.20was.20broken.20for.20Miri.html#226670410">(Feb 17 2021 at 15:14)</a>:</h4>
<p>It also happened on other PRs with the same error:</p>
<ul>
<li><a href="https://github.com/rust-lang/rust/pull/82197#issuecomment-780353543">https://github.com/rust-lang/rust/pull/82197#issuecomment-780353543</a></li>
<li><a href="https://github.com/rust-lang/rust/pull/82192#issuecomment-780152931">https://github.com/rust-lang/rust/pull/82192#issuecomment-780152931</a></li>
</ul>



<a name="226771711"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Toolstate%20update%20was%20broken%20for%20Miri/near/226771711" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> hyd-dev <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Toolstate.20update.20was.20broken.20for.20Miri.html#226771711">(Feb 18 2021 at 06:54)</a>:</h4>
<p>Looks like this is preventing @rust-highfive from creating toolstate broken issue: <a href="https://github.com/rust-lang/rust/issues?q=is%3Aissue+author%3Arust-highfive+label%3AA-miri">https://github.com/rust-lang/rust/issues?q=is%3Aissue+author%3Arust-highfive+label%3AA-miri</a><br>
(it should complain about <a href="https://github.com/rust-lang/rust/issues/82116">#82116</a>)<br>
<a href="/user_uploads/4715/vubtnKQ_7E4RId6R5aBf4sud/image.png">(Miri is now missing from rustup, but no toolstate issue is created)</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/vubtnKQ_7E4RId6R5aBf4sud/image.png" title="(Miri is now missing from rustup, but no toolstate issue is created)"><img src="/user_uploads/4715/vubtnKQ_7E4RId6R5aBf4sud/image.png"></a></div>



<a name="226792668"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Toolstate%20update%20was%20broken%20for%20Miri/near/226792668" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> hyd-dev <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Toolstate.20update.20was.20broken.20for.20Miri.html#226792668">(Feb 18 2021 at 10:45)</a>:</h4>
<p><span class="user-mention silent" data-user-id="374396">hyd-dev</span> <a href="#narrow/stream/242791-t-infra/topic/Toolstate.20update.20was.20broken.20for.20Miri/near/226668340">said</a>:</p>
<blockquote>
<p>Maybe the <code>master</code> job does not use a container, and <code>ubuntu-latest</code> was changed to <code>ubuntu-20.04</code> now: <a href="https://github.com/rust-lang-ci/rust/runs/1913286475#step:1:4">https://github.com/rust-lang-ci/rust/runs/1913286475#step:1:4</a><br>
And <code>ubuntu-20.04</code> uses Python 3 by default: <a href="https://github.com/actions/virtual-environments/issues/1591">https://github.com/actions/virtual-environments/issues/1591</a></p>
</blockquote>
<p>(Thanks <span class="user-mention" data-user-id="125254">@kennytm</span> for the pointer!)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>